-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce sector module #1724
Introduce sector module #1724
Conversation
In file src/ontology/edits/catalog-v001.xml you have now both an
Maybe that is causing the problem? Additionally, I noticed that when I open oeo.omn in your current branch, Protégé adds an additional entry into src/ontology/catalog-v001.xml
|
…catalog Fix 1724 sectors in catalog
….com/OpenEnergyPlatform/ontology into feature-1399-introduce-sector-module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not check commit by commit, but the overall changes in Protégé look fine.
I found one problem regarding some sector individuals. However this problem occurs not only in the feature branch of this PR but also in dev, so it was not introduced by this PR. Thus I created issue #1730
Summary of the discussion
#1399
In this PR, the new sector module is generated and populated with all sectors, sector divisions and many sector individuals which originally lived in oeo-social.
Type of change (CHANGELOG.md)
Added
Updated
sector
andsector division
and subclasses to the new moduleWorkflow checklist
Automation
Closes #
PR-Assignee
term tracker item
Reviewer